Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v3 Features to main branch #1144

Merged
merged 14 commits into from
Sep 9, 2022
Merged

Merge v3 Features to main branch #1144

merged 14 commits into from
Sep 9, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 30, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Base: 87.92% // Head: 88.56% // Increases project coverage by +0.63% 🎉

Coverage data is based on head (f66e568) compared to base (b1d1971).
Patch coverage: 97.54% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   87.92%   88.56%   +0.63%     
==========================================
  Files         203      208       +5     
  Lines        6891     6942      +51     
==========================================
+ Hits         6059     6148      +89     
+ Misses        832      794      -38
Impacted Files Coverage Δ
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 93.78% <ø> (ø)
.../Server/Controllers/v1.0/DeviceModelsController.cs 100.00% <ø> (ø)
...ortal/Server/Controllers/v1.0/DevicesController.cs 100.00% <ø> (ø)
...l/Server/Controllers/v1.0/DevicesControllerBase.cs 96.87% <ø> (ø)
...l/Server/Controllers/v1.0/EdgeDevicesController.cs 100.00% <ø> (ø)
...al/Server/Controllers/v1.0/EdgeModelsController.cs 100.00% <ø> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 100.00% <ø> (ø)
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <ø> (ø)
...rtal/Server/Controllers/v1.0/SettingsController.cs 100.00% <ø> (ø)
...c/AzureIoTHub.Portal/Server/Entities/EntityBase.cs 75.00% <ø> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the v3/main branch 6 times, most recently from 0a5367f to ede0dcc Compare September 5, 2022 08:44
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2022
View reviewed changes
src/AzureIoTHub.Portal.Tests.Unit/Infrastructure/Factories/TableClientFactoryTests.cs
.GetMethod(methodName)
.Invoke(tableClientFactory, Array.Empty<object>()) as TableClient;
// Assert
Assert.AreEqual(tableName, result.Name);

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [result](1) may be null here because of [this](2) assignment.
@kbeaugrand kbeaugrand force-pushed the v3/main branch 8 times, most recently from 8a79f45 to d642127 Compare September 9, 2022 07:50
@kbeaugrand kbeaugrand marked this pull request as ready for review September 9, 2022 16:47
@kbeaugrand kbeaugrand requested a review from a team as a code owner September 9, 2022 16:47
@kbeaugrand
Add target branche to CI actions
be64a77
@kbeaugrand
Add PostgreSQL database to deployment (#1112)
a195a6a 
* Add PostgreSQL database to deployment

* Add ARM lint task to v3-dev branch

* Add github actions to solution file
@kbeaugrand
Feature/add pgsql database connection (#1121)
5b61783 
* Add entityframework + PGSql nuget packages

* Add PGSql database context + initial database creation
@kbeaugrand
Add Quartz.NET Scheduler to server (#1135)
cf8f1eb
@kbeaugrand
Ignore migration files to code coverage
51c51cf
@kbeaugrand
Migrate v3-dev to v3/main branch
a81bc93
@kbeaugrand
Add unit of work and generic repository (#1154)
1fcf9ff 
* Add unit of work and generic repository

* Add infrastructure layer + domain layer
@kbeaugrand
Move Device model property to database (#1155)
be81226
@kbeaugrand
Fix #984 - Refactor DeviceModelPropertiesController (#1159)
5658a1a
kbeaugrand and others added 5 commits September 9, 2022 18:51
@kbeaugrand
Rebase from main
18eb70e
@kbeaugrand
Remove start Azurite from the build pipeline
bd9f374
@hocinehacherouf @kbeaugrand
Add database servcie as adependency to iot hub portal #1175
477ff01
@hocinehacherouf @kbeaugrand
Fix PostgreSQL arm deployment on V3 (#1183)
fb635de 
* Feature: Add PostgreSQL login/password fields to arm ui form #1181

* Fix postgsql arm deployment #1180

* Update temporary arm templates urls for testing

* Update arm templates url to target main branch
@hocinehacherouf @kbeaugrand
Set pgsqlAdminPassword parameter as securestring (#1188)
f66e568
@kbeaugrand kbeaugrand merged commit 1fc869e into main Sep 9, 2022
@kbeaugrand kbeaugrand deleted the v3/main branch September 11, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm-templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbeaugrand @hocinehacherouf